Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Adds task run columns to flow run data table #17200

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 19, 2025

Adds task run columns to flow run data table

Screenshot 2025-02-19 at 11 44 44 AM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 19, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 19, 2025 20:01
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On thought but overall LGTM

Comment on lines 24 to 26
if (taskRunsCount === undefined) {
return "Tasks not found";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably just return null here not not show anything if there are no task runs. Also might be worth checking with adam if we even want to have this column. Since its going to create an api call for each row.

@devinvillarosa devinvillarosa force-pushed the devin/eng-1444-tasks-cells branch from e80c37c to 6c78150 Compare February 19, 2025 20:04
@devinvillarosa devinvillarosa merged commit 8e802bb into main Feb 19, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the devin/eng-1444-tasks-cells branch February 19, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants