Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: adds query to join flow runs with parent flow #17217

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 20, 2025

[UI v2] feat: adds query to join flow runs with parent flow

This query is needed for a basic flow runs table (until the APIs get updated to include both flow_id and flow_name)

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@devinvillarosa devinvillarosa force-pushed the add-join-flow-runs-flows branch from e145969 to 4a69fe8 Compare February 20, 2025 19:05
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 20, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 20, 2025 19:05
* @param filter
* @returns a simplified query object that joins a flow run's pagination data with it's parent flow
*/
export const usePaginateFlowRunswithFlows = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we be better off creating a single query action that does this? That way we can await the flow runs, await the flows, and then combine them. And then we can just use a normal query rather than this custom hook with its custom pending an error states.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing a thread with @desertaxle where we would want to do it this way, so that we won't find ourselves writing so many specific queries for joining data.

Should we continue doing this way?
I do see the benefit of having nice RQ object, but it can become an anti pattern to write specific joining queries vs using re-usable query configs.

@devangrose @desertaxle Any thoughts on how we should continue joining data?

@devinvillarosa devinvillarosa force-pushed the add-join-flow-runs-flows branch 2 times, most recently from 360d3d9 to 519f0d0 Compare February 20, 2025 20:30
@devinvillarosa devinvillarosa marked this pull request as draft February 20, 2025 20:30
@devinvillarosa devinvillarosa force-pushed the add-join-flow-runs-flows branch from 519f0d0 to ee8e123 Compare February 20, 2025 20:32
@devinvillarosa devinvillarosa marked this pull request as ready for review February 20, 2025 20:32
@devinvillarosa devinvillarosa merged commit 5a8808d into main Feb 20, 2025
10 checks passed
@devinvillarosa devinvillarosa deleted the add-join-flow-runs-flows branch February 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants