[UI v2] feat: Start transition flow runs list form data table to cards #17238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinvillarosa
force-pushed
the
flow-runs-card-list
branch
from
1cadcdc to
eb7d449
Compare
devinvillarosa
requested review from
aaazzam,
desertaxle,
devangrose and
pleek91
as code owners
pleek91
approved these changes
Feb 21, 2025
ui-v2/src/components/deployments/deployment-details-upcoming-tab.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+8
to
+16
| type FlowRunCardProps = | ||
| | { | ||
| flowRun: FlowRunRow; | ||
| } | ||
| | { | ||
| flowRun: FlowRunRow; | ||
| checked: boolean; | ||
| onCheckedChange: (checked: boolean) => void; | ||
| }; |
Comment on lines
+3
to
+22
| export const FLOW_RUN_STATES = [ | ||
| "Scheduled", | ||
| "Late", | ||
| "Resuming", | ||
| "AwaitingRetry", | ||
| "AwaitingConcurrencySlot", | ||
| "Pending", | ||
| "Paused", | ||
| "Suspended", | ||
| "Running", | ||
| "Retrying", | ||
| "Completed", | ||
| "Cached", | ||
| "Cancelled", | ||
| "Cancelling", | ||
| "Crashed", | ||
| "Failed", | ||
| "TimedOut", | ||
| ] as const; | ||
| export type FlowRunState = (typeof FLOW_RUN_STATES)[number]; |
There was a problem hiding this comment.
These are state names (vs state types) so lets be specific and call these FlowRunStateNames. Also, important to keep in mind that there can be user provided state names. So if we have the state type, we should work off that. And wherever we use state names we should type them as string rather than a specific union type like this (in components that accept customer runs).
This is helpful for mapping known state names to state types, but we cannot count on the state name being one of these known values.
There was a problem hiding this comment.
thanks, I'll keep that in mind.
I'll keep this for now until I update the zod validation on the routes for this search param
devinvillarosa
force-pushed
the
flow-runs-card-list
branch
from
eb7d449 to
6d4d65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start transition flow runs list form data table to cards
After discussion to use a card UX instead, this PR starts the transition to use cards. Future PRs will slowly build up the cards.
This PR copies over pagination features over from the data table UX
Screen.Recording.2025-02-21.at.10.45.13.AM.mov
Checklist
<link to issue>"mint.json.Relates to #15512