Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefect_service_account can be queried and imported by name, as well as ID #107

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

parkedwards
Copy link
Contributor

@parkedwards parkedwards commented Nov 3, 2023

Note - this PR depends on an upstream Prefect Cloud PR, so the acceptance tests are expected to fail until that change is merged

relates to #103
resolves #101

data "prefect_service_account" "bot" {
  id = "7de0291d-59d0-4d57-a629-fe47960aa61b"
}

# or

data "prefect_service_account" "bot" {
  name = "my-bot-name"
}

as well as

terraform import prefect_service_account.bot name/my-bot-name

@parkedwards parkedwards requested a review from a team as a code owner November 3, 2023 23:11
data "prefect_service_account" "my_existing_bot" {
id = "service-acount-UUID"
data "prefect_service_account" "bot" {
id = "7de0291d-59d0-4d57-a629-fe47960aa61b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it should be fine, this is for the docs pages and that's a random uuid i created just now

data "prefect_service_account" "my_existing_bot" {
id = "service-acount-UUID"
data "prefect_service_account" "bot" {
id = "7de0291d-59d0-4d57-a629-fe47960aa61b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Guessing we do

@parkedwards parkedwards merged commit 86a955c into main Nov 4, 2023
7 checks passed
@parkedwards parkedwards deleted the feat/service-account-query-and-import-by-name branch November 4, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: can't import service accounts
2 participants