-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Deployments): support ParameterOpenAPISchema #263
Conversation
Adds support for the ParameterOpenAPISchema for the Deployment resource. Related to #238 Related to https://linear.app/prefect/issue/PLA-185/support-for-deployments-resource
…t into deployments-support-parameter-schema
@felixpelletier - since you mentioned you were eager for this feature, do you mind taking a look here? Want to make sure this addresses real-world needs. Cheers! |
Sure thing! I know it's an API limitation, and it's probably another team managing this part, but it's kind of limiting to have the parameter schemas field available for creation only. That means that any deployment that needs a change in the list of available parameters in the UI will need a new deployment or a replacement. If we simply replace the old deployment, then we lose any queued/running flow runs, and if we create a new one and switch over gradually, then it's not an ideal process (create the new deployment, release, move all schedules to the new deployment, release, remove old deployment after we're sure we don't need the historical logs, release). We'll probably end up having a single parameter of type "object" named "parameters" and we will do all the parsing and validation ourselves (I believe someone else here already does this). At least this PR will give us the ability to do that. I have two questions:
Let me know if you have any questions. I'm happy to see some movement in here! The company here loves Terraform! |
That's a very fair question - let me reach out to the team and find out more and I'll follow up here.
Great callout, yes this should definitely trigger a replacement. Will add that! |
…t into deployments-support-parameter-schema
We don't update parameterOpenAPISchema because it's not supported by the API, so we don't need to unmarshal the variable here.
Adds support for the ParameterOpenAPISchema for the Deployment resource.
Related to #238
Related to https://linear.app/prefect/issue/PLA-185/support-for-deployments-resource