chore: add foundation for automated Acceptance Testing #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
parkedwards
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
parkedwards
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
parkedwards
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
parkedwards
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
parkedwards
commented
Oct 25, 2023
| ) | ||
| } | ||
|
|
||
| if config.APIKey.IsUnknown() { |
parkedwards
changed the title
parkedwards
changed the title
parkedwards
commented
Oct 25, 2023
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testutils.ProviderConfig + fixtureAccWorkspaceRoleDataSource(owner), |
There was a problem hiding this comment.
we actually dont need to re-specify the provider config, there's an implicit, default one that gets loaded. so long as we pass the environment variables, we wont need this one
parkedwards
commented
Oct 25, 2023
| ) | ||
| } | ||
| // Here, we'll ensure that the /api suffix is present on the endpoint |
There was a problem hiding this comment.
this allows the end user to do something like:
provider "prefect" {
endpoint = "https://api.prefect.cloud"
}
# instead of this, although this would also be accepted
provider "prefect" {
endpoint = "https://api.prefect.cloud/api"
}
parkedwards
commented
Oct 25, 2023
| var apiKey string | ||
| if !config.APIKey.IsUnknown() { |
There was a problem hiding this comment.
we already perform unknown checks on these config values in the lines above
in this case, we want to do a null check. the unknown values would come into play if we're passing in provider configurations that are dependent on other resource attributes that aren't yet know (like the id of a resource that will be created in the same plan)
parkedwards
commented
Oct 25, 2023
| if v := os.Getenv(key); v == "" { | ||
| t.Fatalf("%s must be set for acceptance tests", key) | ||
| } | ||
| } |
There was a problem hiding this comment.
if we miss these env vars during acceptance testing:
$ TF_ACC=1 make test
gotestsum --max-fails=50 ./...
∅ .
∅ internal/api
∅ internal/client
∅ internal/provider
∅ internal/provider/customtypes
∅ internal/testutils
✖ internal/provider/datasources (273ms)
✖ internal/provider/resources (403ms)
=== Failed
=== FAIL: internal/provider/datasources TestAccDatasource_service_account (0.00s)
provider.go:34: PREFECT_API_URL must be set for acceptance tests
=== FAIL: internal/provider/datasources TestAccDatasource_workspace_role_defaults (0.00s)
provider.go:34: PREFECT_API_URL must be set for acceptance tests
=== FAIL: internal/provider/resources TestAccResource_workspace_role (0.00s)
provider.go:34: PREFECT_API_URL must be set for acceptance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #30
resolves #67