Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefect_account_role Datasource #77

Merged
merged 14 commits into from
Oct 27, 2023

Conversation

parkedwards
Copy link
Contributor

@parkedwards parkedwards commented Oct 27, 2023

resolves #39
resolves #76

This PR adds a new datasource for prefect_account_role. Currently, there are no plans to allow practitioners to create custom Account Roles (there is no create endpoint), and we do not allow modifying the default system roles. As such, we will just support reading down either the Admin or Member account roles by name - practitioners can then use the fetched data.prefect_account_role.foobar.id in order to set account membership in a followup resource

@parkedwards parkedwards requested a review from a team as a code owner October 27, 2023 04:14
@parkedwards parkedwards temporarily deployed to Acceptance Tests October 27, 2023 04:14 — with GitHub Actions Inactive
@parkedwards parkedwards temporarily deployed to Acceptance Tests October 27, 2023 04:18 — with GitHub Actions Inactive
@parkedwards parkedwards changed the title feat: prefect_account_role datasource feat: prefect_account_role Datasource Oct 27, 2023
@parkedwards parkedwards temporarily deployed to Acceptance Tests October 27, 2023 04:46 — with GitHub Actions Inactive
@parkedwards parkedwards temporarily deployed to Acceptance Tests October 27, 2023 04:57 — with GitHub Actions Inactive
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.83.5
hooks:
- id: terraform_fmt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@parkedwards parkedwards merged commit 5199e17 into main Oct 27, 2023
5 checks passed
@parkedwards parkedwards deleted the feat/add-account-role-datasource branch October 27, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit configuration Data Source: prefect_account_role
2 participants