-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prefect_account_role
Datasource
#77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
temporarily deployed
to
Acceptance Tests
October 27, 2023 04:14 — with
GitHub Actions
Inactive
parkedwards
temporarily deployed
to
Acceptance Tests
October 27, 2023 04:18 — with
GitHub Actions
Inactive
parkedwards
changed the title
feat:
feat: Oct 27, 2023
prefect_account_role
datasourceprefect_account_role
Datasource
parkedwards
temporarily deployed
to
Acceptance Tests
October 27, 2023 04:46 — with
GitHub Actions
Inactive
parkedwards
temporarily deployed
to
Acceptance Tests
October 27, 2023 04:57 — with
GitHub Actions
Inactive
- repo: https://github.com/antonbabenko/pre-commit-terraform | ||
rev: v1.83.5 | ||
hooks: | ||
- id: terraform_fmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
jamiezieziula
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #39
resolves #76
This PR adds a new datasource for
prefect_account_role
. Currently, there are no plans to allow practitioners to create custom Account Roles (there is no create endpoint), and we do not allow modifying the default system roles. As such, we will just support reading down either theAdmin
orMember
account roles by name - practitioners can then use the fetcheddata.prefect_account_role.foobar.id
in order to set account membership in a followup resource