-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MockingMagician/unitConverter #98
base: main
Are you sure you want to change the base?
MockingMagician/unitConverter #98
Conversation
-designing package - implementing conversion for lengths - implementing general pattern for conversions
Hi @colinpape, @treygrainger, there is someone for checking pull request ? |
@MockingMagician you ready for a review now, or still working on the other conversion metrics? |
I plan to add all the units in the list, but doing it on my own time, you can do the code review and merge if the code is validated. The other units will be for 1.x versions |
@jejopl would you mind reviewing this when you have some time? Per @MockingMagician's comments, it seems like we could get what's there merged if it passes review and the other units could be added later. |
Hi @treygrainger, @jejopl When is this PR, do you want to check it, do I continue it, do we merge this first version already? The other units can be easily added with the system I set up. If you want more units for its release tell me I will implement them. Just tell me if you are still interested ? See you soon |
The idea of this package is to provide a unit conversion.
Currently 3 families are implemented:
Comming next: