Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public vs private tensor_to_matrix(tensor_input) #111

Closed
fnrizzi opened this issue Jan 29, 2024 · 4 comments
Closed

public vs private tensor_to_matrix(tensor_input) #111

fnrizzi opened this issue Jan 29, 2024 · 4 comments

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Jan 29, 2024

do we need this to be public?

def tensor_to_matrix(tensor_input):
def matrix_to_tensor

@jtencer
Copy link
Contributor

jtencer commented Jan 29, 2024

Do we use it anywhere outside of that file?

@fnrizzi
Copy link
Member Author

fnrizzi commented Jan 29, 2024

no, but the questions is whether we want to expose this or not. I don't think we should. We should make it private and MAYBE expose it later if tehre is a real need for it

@eparish1
Copy link
Contributor

@fnrizzi I think we should make it private, I see no real need to expose it at the moment.

@fnrizzi
Copy link
Member Author

fnrizzi commented Jan 29, 2024

i agree, i will do that

@fnrizzi fnrizzi linked a pull request Jan 30, 2024 that will close this issue
@fnrizzi fnrizzi closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants