trial space: improve flow and some doc details, make utils a submodule
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
force-pushed
the
improve_trial_space_doc
branch
from
3f81138 to
0572b9a
Compare
fnrizzi
changed the title
utils a submodule
|
Thanks! This is nice. I'm good with this! |
|
I am ! |
|
Do we want to roll the renaming of "trialspace" into this or do that separately/later and know that that change will also need to touch the docs? |
|
I'm totally fine with doing that later and merging this in now, just want to bring it up. |
|
We will do that separately. I just created a separate issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similarly for the other concrete classes