Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jtencer/issue103 #109

Merged
merged 18 commits into from
Jan 31, 2024
Merged

Jtencer/issue103 #109

merged 18 commits into from
Jan 31, 2024

Conversation

jtencer
Copy link
Contributor

@jtencer jtencer commented Jan 26, 2024

parameter space refactor

@fnrizzi
Copy link
Member

fnrizzi commented Jan 29, 2024

if you rebase the issue with the CI was fixed

@jtencer jtencer linked an issue Jan 30, 2024 that may be closed by this pull request
Support for heterogeneous parameter spaces #103
Closed
eparish1
eparish1 reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@eparish1 eparish1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtencer I like this, I don't see anything that I disagree with. Looks good to me, ready to merge in your opinion?

@jtencer jtencer requested review from eparish1 and fnrizzi January 31, 2024 03:09
@fnrizzi fnrizzi merged commit 00eba63 into develop Jan 31, 2024
6 checks passed
@jtencer jtencer deleted the jtencer/issue103 branch January 31, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnrizzi fnrizzi fnrizzi approved these changes

@eparish1 eparish1 Awaiting requested review from eparish1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for heterogeneous parameter spaces
3 participants
@jtencer @fnrizzi @eparish1