Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#150: reach version 0.1 for parallel version #160

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

cwschilly
Copy link
Collaborator

@cwschilly cwschilly commented Mar 8, 2024

Fixes #150

@cwschilly cwschilly linked an issue Mar 8, 2024 that may be closed by this pull request
@cwschilly cwschilly marked this pull request as draft March 8, 2024 21:27
@cwschilly cwschilly self-assigned this Mar 15, 2024
@cwschilly cwschilly force-pushed the 150-reach-version-01-for-parallel-verion branch from 2bd16f6 to fa97234 Compare April 3, 2024 16:37
@cwschilly cwschilly requested review from fnrizzi and eparish1 April 3, 2024 16:46
@cwschilly cwschilly marked this pull request as ready for review April 3, 2024 16:51
@cwschilly
Copy link
Collaborator Author

@fnrizzi All vector space utils now have a passing MPI test for every serial test

@fnrizzi
Copy link
Member

fnrizzi commented Apr 4, 2024

something here is not right. i am a bit confused by the tests.
say that you want to the orthogonalizer.
can you please rework the tests such that:

  • you create a local and global array
  • each rank executes orthogonalizer on the what you call the GLOBAL array, and then you distribute the result
  • then you do the orthogonalizer opoeration on the distributed array
    the last two things should be equivalent

@cwschilly cwschilly marked this pull request as draft April 4, 2024 13:32
@cwschilly cwschilly requested a review from fnrizzi April 4, 2024 20:05
@cwschilly cwschilly marked this pull request as ready for review April 4, 2024 20:05
@fnrizzi fnrizzi merged commit ae78d44 into develop Apr 9, 2024
6 checks passed
@fnrizzi fnrizzi deleted the 150-reach-version-01-for-parallel-verion branch May 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reach version 0.1 for parallel verion
2 participants