Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated sampler to use model #168

Merged
merged 5 commits into from
Mar 18, 2024
Merged

updated sampler to use model #168

merged 5 commits into from
Mar 18, 2024

Conversation

eparish1
Copy link
Contributor

No description provided.

@fnrizzi
Copy link
Member

fnrizzi commented Mar 18, 2024

all the CI is failing, is this expected because this is wip or this is done and CI should not fail?

@eparish1
Copy link
Contributor Author

@fnrizzi I'm working on fixing it, the fail didn't happen on my machine.

@eparish1 eparish1 requested review from jtencer and fnrizzi March 18, 2024 14:05
@fnrizzi
Copy link
Member

fnrizzi commented Mar 18, 2024

ok ready, i will check!

@fnrizzi
Copy link
Member

fnrizzi commented Mar 18, 2024

all tests pass so i am good

@fnrizzi fnrizzi merged commit c236158 into develop Mar 18, 2024
6 checks passed
@fnrizzi fnrizzi deleted the 165-update-sampling branch May 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants