clarify which protocols the vairous implementations conform to #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some import statements
fnrizzi
reviewed
Mar 27, 2024
romtools/vector_space/__init__.py
Outdated
| @@ -185,7 +185,7 @@ def extents(self) -> Tuple[int, int, int]: | |||
| return self.__basis.shape | |||
|
|
|||
|
|
|||
| class VectorSpaceFromPOD: | |||
| class VectorSpaceFromPOD(VectorSpace): | |||
There was a problem hiding this comment.
i don't think we should do this. THis is misleading IMO because it hints at inheritance but we are more relaxed than that. It is already clear that this conforms to the protocol. Instead of this inheritance i would suggest maybe adding a comment that says that.
Also, if one changes the name of the protocol we have this too. If we don't do this, that is not a problem.
not that we will change the name, but that is the whole point of defining just an interface/protocol.
There was a problem hiding this comment.
same for the other change similar
|
switched to including statement in the docstrings rather than using inheritance |
fnrizzi
changed the title
fnrizzi
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…some import statements