Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW UI] Update options page #976

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

[NEW UI] Update options page #976

wants to merge 13 commits into from

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Oct 28, 2024 •
edited
Loading

Questions Answers
Description? Handle update option with a brand new page
Type? new feature
BC breaks? Yes, the config var PS_AUTOUP_KEEP_EMAIL is now PS_AUTOUP_REGEN_EMAIL
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Update options can be updated via the new UI. Refreshing a page after an option is switched on or off must keep its value.

image

@Quetzacoalt91 Quetzacoalt91 self-assigned this Oct 28, 2024
@Quetzacoalt91 Quetzacoalt91 added the Blocked Status: The issue is blocked by another task label Oct 29, 2024
@ga-devfront ga-devfront changed the title Update options page [NEW UI] Update options page Oct 29, 2024
@Quetzacoalt91
Copy link
Member Author

Requires the 2 following PRs to be merged:

@Quetzacoalt91 Quetzacoalt91 removed the Blocked Status: The issue is blocked by another task label Nov 4, 2024
@Quetzacoalt91 Quetzacoalt91 force-pushed the update-options-page branch 2 times, most recently from a49d563 to f135bcb Compare November 8, 2024 11:07
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review November 8, 2024 11:11
M0rgan01
M0rgan01 reviewed Nov 8, 2024
View reviewed changes
README.md Show resolved Hide resolved
classes/Analytics.php Outdated Show resolved Hide resolved
controllers/admin/self-managed/UpdatePageUpdateOptionsController.php Outdated Show resolved Hide resolved
@ga-devfront ga-devfront added this to the 7.0.0 milestone Nov 12, 2024
M0rgan01
M0rgan01 previously approved these changes Nov 13, 2024
View reviewed changes
@Quetzacoalt91
Copy link
Member Author

Blocked until we get an additional acceptance criteria from Geric.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ga-devfront ga-devfront ga-devfront left review comments

@M0rgan01 M0rgan01 M0rgan01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Quetzacoalt91 Quetzacoalt91

Labels
waiting for PM
Projects
PR Dashboard
Status: Ready for review
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Quetzacoalt91 @M0rgan01 @ga-devfront