Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multistore list block #613

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feature: Multistore list block #613

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
357492c
Add is_shop context to sql query
Triloworld Oct 30, 2023
dad7fa7
PHP CS fixes
Triloworld Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions classes/ReassuranceActivity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,12 @@ public static function getAllBlock()
*/
public static function getAllBlockByStatus($id_lang = 1)
{
$id_shop = (int)Context::getContext()->shop->id;
Triloworld marked this conversation as resolved.
Show resolved Hide resolved

$sql = 'SELECT * FROM `' . _DB_PREFIX_ . 'psreassurance` pr
LEFT JOIN ' . _DB_PREFIX_ . 'psreassurance_lang prl ON (pr.id_psreassurance = prl.id_psreassurance)
WHERE prl.id_lang = "' . (int) $id_lang . '"
AND prl.id_shop = "' . (int) $id_shop . '"
Copy link
Contributor

@leemyongpakvn leemyongpakvn Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is just a small part of what PR 336 - Remove broken multishop support removed since March 2022. If we dive deeper in that PR changes, we can see to bring this line back we need to bring its prerequisite line back too.
For a whole view to make sure we won't bring an old feature back with known issues, I suggest reading the whole PR336 changes and conversation.

AND pr.status = 1
ORDER BY pr.position';

Expand Down