Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very basic validator functionality #96

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Conversation

mattdf
Copy link
Member

@mattdf mattdf commented Feb 4, 2025

Implement #55

@mattdf mattdf marked this pull request as ready for review February 5, 2025 11:22
@mattdf mattdf requested a review from JannikSt February 5, 2025 11:36
Copy link
Member

@JannikSt JannikSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only supporting GPUs? Should also be doable by a normal CPU I assume?
Something is not working on my local test - I see that the requests actually come in on the node. Validator:

[INFO  validator] Non validated nodes: [DiscoveryNode { node: Node { id: "0x66295E2B4A78d1Cb57Db16Ac0260024900A5BA9B", provider_address: "0xC489fabaA6a5D4A49dF0aa590a779880C75fC405", ip_address: "0.0.0.0", port: 8091, compute_pool_id: 0, compute_specs: Some(ComputeSpecs { gpu: None, cpu: Some(CpuSpecs { cores: Some(14), model: Some("Apple M3 Max") }), ram_mb: Some(36864), storage_gb: Some(926), storage_path: None }) }, is_validated: false, is_active: false }]
Challenge request: ChallengeRequest { rows_a: 3, cols_a: 3, data_a: [0.7293360311008195, 0.957463411875078, 0.39101130831465003, 0.32466191530271304, 0.6706602400858217, 0.9622708286095232, 0.6070233504229647, 0.05688881081728603, 0.4935405642773578], rows_b: 3, cols_b: 3, data_b: [0.890868105602634, 0.18381199647220914, 0.382563260782925, 0.3713313899316728, 0.18018971621669455, 0.27968305311288244, 0.7960309243217891, 0.9931346929402032, 0.21043724085438886] }
Challenge post url: http://0.0.0.0:8091/challenge/submit
Challenge response: Response { url: "http://0.0.0.0:8091/challenge/submit", status: 400, headers: {"content-length": "17", "content-type": "text/plain; charset=utf-8", "date": "Wed, 12 Feb 2025 01:51:53 GMT"} }
[ERROR validator] Failed to challenge node 0x66295E2B4A78d1Cb57Db16Ac0260024900A5BA9B: Err(Error("expected value", line: 1, column: 1))

@mattdf mattdf force-pushed the feature/validator-challenge branch from 22b14bb to 9a85c57 Compare February 12, 2025 08:46
@mattdf mattdf merged commit e172fbd into develop Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants