Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented templates of mesh::boundary #212

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Implemented templates of mesh::boundary #212

merged 1 commit into from
Dec 3, 2024

Conversation

Rohit-Kakodkar
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar commented Dec 2, 2024

Description

Implements #205

Issue Number

Closes #205

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@Rohit-Kakodkar
Copy link
Collaborator Author

Can one of you have a look at this PR?

Copy link
Collaborator

@icui icui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsawade lsawade merged commit c8e4438 into issue-200 Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants