Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements dimension specific axial and tangential elements #216

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Implements dimension specific axial and tangential elements #216

merged 3 commits into from
Dec 3, 2024
+44 −21

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Dec 3, 2024 •
edited
Loading

Description

Adds dimension flag to all

Issue Number

closes #207, closes #208

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade changed the base branch from main to devel December 3, 2024 00:58
@lsawade lsawade linked an issue Dec 3, 2024 that may be closed by this pull request
Create templated class and specialization for specfem::mesh::tangential_elements #207
Closed
@Rohit-Kakodkar
Copy link
Collaborator

retest this please

1 similar comment
@Rohit-Kakodkar
Copy link
Collaborator

retest this please

Rohit-Kakodkar
Rohit-Kakodkar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsawade lsawade requested a review from icui December 3, 2024 15:58
Rohit-Kakodkar
Rohit-Kakodkar requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge branch needs to change from devel to issue-200

@lsawade lsawade changed the base branch from devel to issue-200 December 3, 2024 16:01
@lsawade
Copy link
Collaborator Author

lsawade commented Dec 3, 2024

Changed the base. We should have done that from the start since 2 PR's were already merged into devel.

@Rohit-Kakodkar
Copy link
Collaborator

Changed the base. We should have done that from the start since 2 PR's were already merged into devel.

ughh, agreed! Yeah I see control nodes was merged into devel. The parameters was merged into issue-200

@Rohit-Kakodkar
Copy link
Collaborator

Going to add a review required before merge guard on the devel branch. So github will explicitly require you to override the review process

Rohit-Kakodkar
Rohit-Kakodkar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsawade
Copy link
Collaborator Author

lsawade commented Dec 3, 2024

hello

@lsawade lsawade requested review from Rohit-Kakodkar and removed request for Rohit-Kakodkar December 3, 2024 18:12
@lsawade
Copy link
Collaborator Author

lsawade commented Dec 3, 2024

retest this

@lsawade
Copy link
Collaborator Author

lsawade commented Dec 3, 2024

Tested locally. Merging.

@lsawade lsawade merged commit da2957d into issue-200 Dec 3, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohit-Kakodkar Rohit-Kakodkar Rohit-Kakodkar approved these changes

@icui icui Awaiting requested review from icui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lsawade @Rohit-Kakodkar