Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 1.21.3 Support #936

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

Conversation

GroobleDierne
Copy link
Contributor

@GroobleDierne GroobleDierne commented Oct 27, 2024

Fixes #929, #928

TODO:

  • Protocol
  • entities.json (waiting on minecraft-data-generator)
  • tints.json is likely incorrect

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

Can you point missing files to 1.21.1 for now

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

Let's open an nmp and mineflayer PRs using this

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

nmp and mineflayer PRs

PrismarineJS/node-minecraft-protocol#1347
PrismarineJS/mineflayer#3489

fail due to wrong protocol as expected

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

see https://github.com/extremeheat/extracted_minecraft_data/pulls as a source of info for the protocol

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

@GroobleDierne
Copy link
Contributor Author

see https://github.com/extremeheat/extracted_minecraft_data/pulls as a source of info for the protocol

I'm using yarn because some files failed to decompile in extremheat's repository.
Anyway, I'll stop here for tonight.

@rom1504
Copy link
Member

rom1504 commented Oct 31, 2024

@GroobleDierne
Copy link
Contributor Author

https://github.com/PrismarineJS/node-minecraft-protocol/actions/runs/11543601911/job/32356083688 now passing but still some packet errors

I still need to implement one or two server-bound packets and the Slot type is messed up which causes quite a lot of packets to throw errors sometimes. I'm also stuck with the unlock_recipes packet, @extremeheat could you take a look at it?

@rom1504
Copy link
Member

rom1504 commented Nov 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Minecraft PC 1.21.3
3 participants