Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (spelling) scafold -> scaffold #340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liquidsquid1
Copy link

There has been a spelling mistake for quite some time in the code project, this pull request aims to resolve the spelling mistake so people can use proper English in their code without confusion.

@liquidsquid1
Copy link
Author

Pull request will be in draft as I need to fix compiling errors. Bear with me.

@liquidsquid1 liquidsquid1 marked this pull request as draft September 6, 2024 18:06
@liquidsquid1 liquidsquid1 marked this pull request as ready for review September 6, 2024 18:10
@IceTank
Copy link
Collaborator

IceTank commented Nov 7, 2024

This is unfortunately a breaking API change and should wait until a new major release is made. Changing it now will break every library or program that currently uses pathfinder and modifies the allowed list of blocks to use.

@IceTank IceTank added the next major release Breaking API changes waiting for major updates label Nov 7, 2024
@IceTank
Copy link
Collaborator

IceTank commented Nov 7, 2024

But yes, as soon as a major release is made, we can implement this change. But making new major releases can confuse people, so it should be reserved for major updates that add or change major functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next major release Breaking API changes waiting for major updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants