Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle passengers array in entities being null #3584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dueel
Copy link

@Dueel Dueel commented Feb 14, 2025

Fixes TypeError: Cannot read properties of undefined (reading 'passengers') by adding passengers array in setEntityData

Copy link
Member

@extremeheat extremeheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not fix the error you state in the PR. That does not state that passengers is missing, but that passengers is being read from an null/undefined object. Also, this will erase the passengers field. That doesn't seem intentional.

@Dueel Dueel requested a review from extremeheat February 14, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants