Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bedrock support, add blockVariantsByStateId map #23

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Bedrock support, add blockVariantsByStateId map #23

wants to merge 13 commits into from

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Jan 10, 2023 •
edited
Loading

  • Add bedrock support
    • for now assets are just mapped to pc data
    • currently only testing bedrock 1.19.1, can add other versions later after updates to mc-data
  • Implement blockVariantsByStateId from prismarine-viewer with bedrock handling inside mc-assets, this can be useful outside of prismarine-viewer

needs PrismarineJS/node-minecraft-data#257 merge & release

@extremeheat extremeheat marked this pull request as draft January 10, 2023 03:21
@rom1504
Copy link
Member

rom1504 commented Jan 21, 2023

failing

@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

what is the status here

@extremeheat
Copy link
Member Author

Blocked by PrismarineJS/node-minecraft-data#257

@socket-security
Copy link

socket-security bot commented Mar 25, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@extremeheat extremeheat marked this pull request as ready for review March 25, 2023 18:22
@rom1504
Copy link
Member

rom1504 commented May 28, 2023

@extremeheat do you think this is ready ?

@rom1504
Copy link
Member

rom1504 commented Nov 5, 2023

@extremeheat what do you think of this PR ?

@socket-security Socket Security
Copy link

socket-security bot commented Jun 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, eval, filesystem Transitive: shell +79 7.02 MB juergba
npm/[email protected] Transitive: environment, eval, filesystem, shell +28 232 MB rom1504
npm/[email protected] Transitive: environment, eval +17 232 MB rom1504

View full report↗︎

@extremeheat
Copy link
Member Author

Yeah should be mergable, I fixed the conflicts.

@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

This needs resolving one more time sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extremeheat @rom1504