Skip to content

Commit

Permalink
fix: analysis-bucket-file delete operation & auth plugin nuxt-app access
Browse files Browse the repository at this point in the history
  • Loading branch information
tada5hi committed Jun 14, 2024
1 parent cfc4cbb commit 86e3a2d
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 21 deletions.
1 change: 0 additions & 1 deletion packages/client-ui/pages/analyses/[id]/results.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export default defineNuxtComponent({
<FAnalysisBucket :query="query">
<template #default="{ data: bucket }">
<FAnalysisBucketFiles
v-if="entity"
:query="{ filters: { bucket_id: bucket.id } }"
>
<template #itemActions="{ data }">
Expand Down
25 changes: 18 additions & 7 deletions packages/client-ui/plugins/01.auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import { install } from '@authup/client-web-kit';
import type { Pinia } from 'pinia';
import { useCookie } from '#imports';
import { tryUseNuxtApp, useCookie } from '#imports';

export default defineNuxtPlugin({
setup(ctx) {
Expand All @@ -18,16 +18,27 @@ export default defineNuxtPlugin({
pinia: ctx.$pinia as Pinia,
baseURL,
cookieSet: (key, value) => {
const cookie = useCookie(key);
cookie.value = value;
const app = tryUseNuxtApp();
if (app) {
const cookie = useCookie(key);
cookie.value = value;
}
},
cookieUnset: (key) => {
const cookie = useCookie(key);
cookie.value = null;
const app = tryUseNuxtApp();
if (app) {
const cookie = useCookie(key);
cookie.value = null;
}
},
cookieGet: (key) => {
const cookie = useCookie(key);
return cookie.value;
const app = tryUseNuxtApp();
if (app) {
const cookie = useCookie(key);
return cookie.value;
}

return null;
},
});
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default defineComponent({
},
setup(props, setup) {
const manager = createEntityManager({
type: `${DomainType.ANALYSIS_FILE}`,
type: `${DomainType.ANALYSIS_BUCKET_FILE}`,
props,
setup,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const FAnalysisBucketFiles = defineComponent({
render,
setDefaults,
} = createList({
type: `${DomainType.ANALYSIS_FILE}`,
type: `${DomainType.ANALYSIS_BUCKET_FILE}`,
props,
setup,
});
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/domains/analysis-bucket-file/entity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ export interface AnalysisBucketFile {
}

export type AnalysisFileEventContext = DomainEventBaseContext & {
type: `${DomainType.ANALYSIS_FILE}`,
type: `${DomainType.ANALYSIS_BUCKET_FILE}`,
data: AnalysisBucketFile
};
2 changes: 1 addition & 1 deletion packages/core/src/domains/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export enum DomainType {
SERVICE = 'service',
ANALYSIS = 'analysis',
ANALYSIS_BUCKET = 'analysisBucket',
ANALYSIS_FILE = 'analysisFile',
ANALYSIS_BUCKET_FILE = 'analysisBucketFile',
ANALYSIS_LOG = 'analysisLog',
ANALYSIS_NODE = 'analysisNode',
}
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/domains/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export type DomainEventContext<T extends `${DomainType}` | `${DomainSubType}`> =
AnalysisBucketEventContext :
T extends `${DomainType.ANALYSIS_LOG}` ?
AnalysisLogEventContext :
T extends `${DomainType.ANALYSIS_FILE}` ?
T extends `${DomainType.ANALYSIS_BUCKET_FILE}` ?
AnalysisFileEventContext :
T extends `${DomainType.ANALYSIS_NODE}` | `${DomainSubType.ANALYSIS_NODE_IN}` | `${DomainSubType.ANALYSIS_NODE_OUT}` ?
TrainStationEventContext :
Expand All @@ -81,7 +81,7 @@ export type DomainEntity<T extends `${DomainType}` | `${DomainSubType}`> =
AnalysisBucket :
T extends `${DomainType.ANALYSIS_LOG}` ?
AnalysisLog :
T extends `${DomainType.ANALYSIS_FILE}` ?
T extends `${DomainType.ANALYSIS_BUCKET_FILE}` ?
AnalysisBucketFile :
T extends `${DomainType.ANALYSIS_NODE}` | `${DomainSubType.ANALYSIS_NODE_IN}` | `${DomainSubType.ANALYSIS_NODE_OUT}` ?
AnalysisNode :
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ async function publishEvent(
await publishDomainEvent(
useRedisPublishClient(),
{
type: DomainType.ANALYSIS_FILE,
type: DomainType.ANALYSIS_BUCKET_FILE,
event,
data,
},
[
{
channel: (id) => buildDomainChannelName(DomainType.ANALYSIS_FILE, id),
channel: (id) => buildDomainChannelName(DomainType.ANALYSIS_BUCKET_FILE, id),
},
{
channel: (id) => buildDomainChannelName(DomainType.ANALYSIS_FILE, id),
channel: (id) => buildDomainChannelName(DomainType.ANALYSIS_BUCKET_FILE, id),
namespace: buildDomainNamespaceName(data.realm_id),
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function registerAnalysisFileSocketHandlers(socket: ResourcesNamespaceSoc
if (!socket.data.userId && !socket.data.robotId) return;

socket.on(
buildDomainEventSubscriptionFullName(DomainType.ANALYSIS_FILE, DomainEventSubscriptionName.SUBSCRIBE),
buildDomainEventSubscriptionFullName(DomainType.ANALYSIS_BUCKET_FILE, DomainEventSubscriptionName.SUBSCRIBE),
async (target, cb) => {
if (!socket.data.abilities.has(PermissionID.ANALYSIS_EDIT)) {
if (isEventCallback(cb)) {
Expand All @@ -38,7 +38,7 @@ export function registerAnalysisFileSocketHandlers(socket: ResourcesNamespaceSoc
return;
}

subscribeSocketRoom(socket, buildDomainChannelName(DomainType.ANALYSIS_FILE, target));
subscribeSocketRoom(socket, buildDomainChannelName(DomainType.ANALYSIS_BUCKET_FILE, target));

if (isEventCallback(cb)) {
cb(null);
Expand All @@ -47,9 +47,9 @@ export function registerAnalysisFileSocketHandlers(socket: ResourcesNamespaceSoc
);

socket.on(
buildDomainEventSubscriptionFullName(DomainType.ANALYSIS_FILE, DomainEventSubscriptionName.UNSUBSCRIBE),
buildDomainEventSubscriptionFullName(DomainType.ANALYSIS_BUCKET_FILE, DomainEventSubscriptionName.UNSUBSCRIBE),
(target) => {
unsubscribeSocketRoom(socket, buildDomainChannelName(DomainType.ANALYSIS_FILE, target));
unsubscribeSocketRoom(socket, buildDomainChannelName(DomainType.ANALYSIS_BUCKET_FILE, target));
},
);
}

0 comments on commit 86e3a2d

Please sign in to comment.