Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Update all-the-things to current versions #481

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

hacklschorsch
Copy link
Member

This is WIP to upgrade ZKAPAuthorizer to current versions of everything.

@hacklschorsch
Copy link
Member Author

Progress! Typecheck/Black runs now and fails:

Oh no! 💥 💔 💥
18 files would be reformatted, 48 files would be left unchanged.

@hacklschorsch
Copy link
Member Author

Digging after the macos build failures it looks like it's trying to build wheels for python_challenge_bypass_ristretto and fails. I connected to CircleCI via SSH and looked around and it seems like this can't work, the source isn't checked out completely (no git submodules, that's where the following error in CI comes from) and there's no rust toolchain at all.

error: [Errno 2] No such file or directory: './challenge-bypass-ristretto-ffi'

It looks like macOS ZKAPAuthorizer relies on being able to download prebuilt binary wheels - and indeed, for older versions, pypi has binaries around, for exmaple: https://pypi.org/project/python-challenge-bypass-ristretto/2023.1.23rc2/#files

@crwood I think we need to fix the python_challenge_bypass_ristretto pypi upload to make progress with the ZKAPAuthorizer macos builds. I created LeastAuthority/python-challenge-bypass-ristretto#64 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant