Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improved Modal Overlay Design and Input Field Accessibility #1000

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

shantanu020
Copy link
Contributor

@shantanu020 shantanu020 commented Oct 18, 2024

Improved Modal Overlay Design and Input Field Accessibility

Related Issue

Bug: #999

Description

This PR addresses several issues with the form's modal overlay and input field accessibility, improving user experience by enhancing contrast, alignment, and adding necessary functionality.

  • Fixed low contrast on modal text to improve readability.
  • Ensured modal fully overlays the background to prevent the star rating from showing through.

No additional dependencies are required for this change.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

Before:

Screenshot 2024-10-18 211803

  • Modal overlay shows star rating from the background.
  • Modal text has low contrast.

After:

Screenshot 2024-10-18 214918

  • Modal completely overlays background with improved contrast.

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 4:43pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 4c48043
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/671290334fca2900080d00f3
😎 Deploy Preview https://deploy-preview-1000--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shantanu020
Copy link
Contributor Author

I made the required changes to enhance ui of the custom-alert popup

@PriyaGhosal PriyaGhosal merged commit c682b26 into PriyaGhosal:main Oct 19, 2024
7 of 16 checks passed
@PriyaGhosal
Copy link
Owner

@shantanu020 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

@shantanu020
Copy link
Contributor Author

Thank You ! @PriyaGhosal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants