Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified carousel to display proper tiles #1582

Closed
wants to merge 2 commits into from

Conversation

shreya2k3
Copy link
Contributor

Related Issue

Modified the carousel on the home page to show the correct number of tiles.

Fixes: #1491

Description

Earlier uneven number of carousel was shown , but now within each slider only 3 carousel tiles are shown.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

Before Change
image

After Change
image

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 26, 2024

Deployment failed with the following error:

Resource is limited - try again in 1 minute (more than 100, code: "api-deployments-free-per-day").

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 0bd5fd7
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/671ddabc7f31b40008434195
😎 Deploy Preview https://deploy-preview-1582--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shreya2k3
Copy link
Contributor Author

@PriyaGhosal Please merge my PR

@PriyaGhosal
Copy link
Owner

@shreya2k3 Please see the conflicts .

@PriyaGhosal PriyaGhosal reopened this Oct 27, 2024
Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 6:16am

@shreya2k3
Copy link
Contributor Author

@PriyaGhosal I have Resolved the conflicts

@PriyaGhosal
Copy link
Owner

@shreya2k3 There are still some conflicts .Please resolve them

@shreya2k3 shreya2k3 closed this Oct 28, 2024
@shreya2k3 shreya2k3 deleted the carousel-update branch October 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: The half slider tile in exclusive deals and offer does not look good
2 participants