Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navbar visibility #1616

Closed
wants to merge 3 commits into from

Conversation

KrishChothani
Copy link
Contributor

Fixes: #1614

Description

Text are not visible in navbar as scrolling the page

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

BEFORE ::
image

AFTER ::
image

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 6:23am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 82a4999
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/671ddc3b7bbe9700089b8a61
😎 Deploy Preview https://deploy-preview-1616--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KrishChothani
Copy link
Contributor Author

If possible, I request to be considered for Level 2. It’s not just 8 lines of code; it’s a significant improvement for the website!

@PriyaGhosal
Copy link
Owner

@KrishChothani Sorry, This issue has already been addressed Find another issue or feature to contribute to. Thank you!

@KrishChothani
Copy link
Contributor Author

KrishChothani commented Oct 28, 2024

Hey @PriyaGhosal
I don't know why are you not assigned this just because current navbar is change by me . You can seen that code .
I also mentioned in #1633 which you are merged .
some Issue cause by me like ( Meged 2 to more PR in same PR ). I add that changes in that PR;
and if you give me level 2 in #1633 as also seen that PR then I have no Problem.
If you can assign as level 1 or 2 for this PR this will very helpful for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG : Improve Navbar and Text Visibility
2 participants