Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pop up dialog box for Polls/Survey done ! #1765 🌟🌟🌟 #1766

Closed
wants to merge 2 commits into from

Conversation

Subhajit-2023-44
Copy link
Contributor

@Subhajit-2023-44 Subhajit-2023-44 commented Oct 29, 2024

Hello, PR
Add new feature - #1765
Add a pop up dialog box for Polls/Survey done properly -

Untitled.video.-.Made.with.Clipchamp.-.2024-10-30T044544.462.mp4

Screenshot 2024-10-30 043451
Screenshot 2024-10-30 043519

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:25pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 6d84732
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6723854a4ebe230008baa837
😎 Deploy Preview https://deploy-preview-1766--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal please merge my PR with level 3

I have added this new feature correctly (if you vote once, you won't see it again after reload..)..

🟠Adding Polls/Survey related to your website, content or products can offer several benefits:

⚪Polls/Survey encourage user interaction, making visitors feel more involved with your site.
⚪They provide direct feedback on user preferences, helping you understand your audience better.
⚪Polls/Survey results can guide future content creation or product development based on what your audience cares about.

Thank You

@PriyaGhosal
Copy link
Owner

@Subhajit-2023-44 One popup was enough .... Anybody would get irritated on getting two pop-up ... You can add it in side like the cookie policy

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 One popup was enough .... Anybody would get irritated on getting two pop-up ... You can add it in side like the cookie policy

@PriyaGhosal Users will not have any problem for this, because if you vote once, you won't see it again after reload.. its a nice feature..

And it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users..

I have done this before on some website they also suggested this and add level 3..

@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal please merge my PR with level 3

Thank You

@PriyaGhosal
Copy link
Owner

@Subhajit-2023-44 BuddyTrail has one popup already... Two pop is something not desirable

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Oct 30, 2024

@Subhajit-2023-44 BuddyTrail has one popup already... Two pop is something not desirable

@PriyaGhosal I have done this same thing on some other website they also have two popup one newsletter and one for survey... that's why i add this as a popup.. And it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users..

you said "Two pop is something not desirable" but i don't think because its a survey, it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users... if you vote once, you won't see it again after reload..

@PriyaGhosal please understand and merge my PR with label

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Oct 30, 2024

@PriyaGhosal & something is wrong in your newsletter popup because it shows up again after sign up.. which doesn't good

That's why you maybe think Two pop is something not desirable

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Oct 31, 2024

@PriyaGhosal ? please merge my PR

@PriyaGhosal
Copy link
Owner

@Subhajit-2023-44 Please see the conflicts .

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Oct 31, 2024

@Subhajit-2023-44 Please see the conflicts .

@PriyaGhosal done

image

@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal

1 similar comment
@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal

@PriyaGhosal
Copy link
Owner

@Subhajit-2023-44 Two pop-up is not looking good ........... Find another issue or feature to contribute to. Thank you!

@PriyaGhosal PriyaGhosal closed this Nov 5, 2024
@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal & something is wrong in your newsletter popup because it shows up again after sign up.. which doesn't good

That's why you maybe think Two pop is something not desirable

@PriyaGhosal ??

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 Please see the conflicts .

@PriyaGhosal You said solve conflicts, i solve conflicts and wait 5 days, and now why you closed my pr ? 😭😭

image

Please merge my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants