Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribe #1849

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Add subscribe #1849

merged 2 commits into from
Nov 10, 2024

Conversation

haseebzaki-07
Copy link
Contributor

Related Issue

fixes #1846

Description

This PR adds the backend implementation for subscribe us also the frontend codes for calling the API.
Backend is working file, just a bug in the frontend the "email" field in not populating.

issue #1846

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2024-11-01 130113
WhatsApp Image 2024-11-01 at 1 13 01 PM (1)

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 6:43am

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 7eabd3a
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/672b0ff64a588a00080ef52a
😎 Deploy Preview https://deploy-preview-1849--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haseebzaki-07
Copy link
Contributor Author

hey @PriyaGhosal please check this PR

@haseebzaki-07
Copy link
Contributor Author

@PriyaGhosal please check this pR

@PriyaGhosal
Copy link
Owner

Please see the conflicts .

@haseebzaki-07
Copy link
Contributor Author

@PriyaGhosal resolved the conflicts

@PriyaGhosal PriyaGhosal merged commit 387a9b3 into PriyaGhosal:main Nov 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Subscribe us
2 participants