Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Feat: Adding searching and sorting functionality in Paris page #1858 #1859

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

KrishPatel1205
Copy link
Contributor

@KrishPatel1205 KrishPatel1205 commented Nov 1, 2024

Related Issue

#1858
Fixes: #1858

Description

On the Paris page where the hotels are displayed there is no option to search hotels by their name or sort the hotel by their price such as 'high to low' or 'low to high' or 'featured.

I added the following functionalities to the page:

  • Sorting
  • Searching

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

The feature looks like:
Screenshot 2024-11-01 at 5 17 24 PM

The feature looks like this on the page:
Screenshot 2024-11-01 at 5 17 44 PM

The feature works as follows:
https://github.com/user-attachments/assets/49146f3e-4406-48bd-a8c6-bc8bc5906b44

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 11:59am

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 153333c
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6724c2b35fba6c0008d4b900
😎 Deploy Preview https://deploy-preview-1859--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KrishPatel1205 KrishPatel1205 changed the title Feat: Adding searching and sorting functionality in Paris page #1858 [FIXED] Feat: Adding searching and sorting functionality in Paris page #1858 Nov 1, 2024
@KrishPatel1205
Copy link
Contributor Author

@PriyaGhosal please check this out

@PriyaGhosal PriyaGhosal merged commit 4e6e580 into PriyaGhosal:main Nov 10, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Adding searching and sorting functionality in Paris page
2 participants