Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Responsive pop up dialog box for subscribing to newsletter done ! #1923 #1924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Subhajit-2023-44
Copy link
Contributor

Hello, PR
Fixed issue - #1923

Now after signing up this popup will not show anymore..

Screenshot 2024-11-06 022528

I first tried doing this on the existing popup but it had so many issues, the whole thing had to be changed. So I added a new popup..

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:43pm

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 41bcb0a
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6730d4a20a038c00097edd84
😎 Deploy Preview https://deploy-preview-1924--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Nov 5, 2024

I added a new Responsive pop up dialog box for subscribing to newsletter, because the existing popup is not responsive, I first tried doing this on the existing popup but it had so many issues, the whole thing had to be changed. So I added a new popup..

Now after signing up this popup will not show anymore..

@PriyaGhosal please merge my PR

Thank you

@Subhajit-2023-44
Copy link
Contributor Author

@PriyaGhosal

@PriyaGhosal
Copy link
Owner

@Subhajit-2023-44 Please see the conflicts

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 Please see the conflicts

now time is over 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants