Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page header#190 #199

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Login page header#190 #199

merged 2 commits into from
Oct 8, 2024

Conversation

Ananya-vastare
Copy link
Contributor

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Fixes: #(issue no.)190

Description

I have removed the bug in the login page to make sure that the expected output is displayed on the screen
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

  • [ X] Bug fix
  • [X ] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Change13

Checklist:

  • [ X] I have made this change from my own.
  • I have taken help from some online resources.
  • [X ] My code follows the style guidelines of this project.
  • [ X] I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:00pm

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for preeminent-madeleine-1a49e0 ready!

Name Link
🔨 Latest commit b486c75
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-madeleine-1a49e0/deploys/6703db5bc807a50008cb8b10
😎 Deploy Preview https://deploy-preview-199--preeminent-madeleine-1a49e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for scintillating-paletas-281a2f ready!

Name Link
🔨 Latest commit b486c75
🔍 Latest deploy log https://app.netlify.com/sites/scintillating-paletas-281a2f/deploys/6703db5bfc705600081d6fe2
😎 Deploy Preview https://deploy-preview-199--scintillating-paletas-281a2f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit e37bfda into PriyaGhosal:main Oct 8, 2024
9 checks passed
@PriyaGhosal
Copy link
Owner

@Ananya-vastare These small changes can't be addressed as contribution. Find another issue or feature to contribute to. Thank you!

@Ananya-vastare
Copy link
Contributor Author

Ananya-vastare commented Oct 8, 2024

But I have sensed a bug here how is my contirbution small @PriyaGhosal is it because of the change in the code is not that much??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants