Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added password toggle and improved UI #286

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Added password toggle and improved UI #286

merged 1 commit into from
Oct 8, 2024

Conversation

kushal7201
Copy link
Contributor

Issue: #279

Description

  • Password Toggle: Add a clickable eye icon beside the password fields and use JavaScript to toggle the type attribute between "password" and "text" to show or hide the password.

  • Validation Feedback: Add an asterisk () after each field label (Full Name, Email*, etc.) using HTML/CSS for required fields.

  • Update Contrast: Modify the CSS color property of the "Sign in" link to a darker shade (e.g., #000 or a color with higher contrast) to meet accessibility standards for better readability.

Type of PR

  • Feature enhancement

Screenshots / videos (if ap

  • Before:
    brave_XASPXylWHd
    applicable)
    brave_KJMl8UCy3d

  • After:
    brave_6peSCnjuiz
    brave_W5R1Dnd9YI

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:22am

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 18e35a1
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/67051608a47905000816f20b
😎 Deploy Preview https://deploy-preview-286--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kushal7201
Copy link
Contributor Author

@PriyaGhosal Kindly review and merge my PR

@PriyaGhosal PriyaGhosal merged commit a93066c into PriyaGhosal:main Oct 8, 2024
7 checks passed
@PriyaGhosal
Copy link
Owner

@kushal7201 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants