Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on issue #309 #310

Closed
wants to merge 3 commits into from

Conversation

sarinsanyal
Copy link
Contributor

@sarinsanyal sarinsanyal commented Oct 8, 2024

Related Issue

Adds good looks to the Sign Up Navbar and added top-bottom margin to the main div.

Fixes: #309

Description

Based of Issue #309, fixed the navbar of the Sign Up page by adding background-color black. The Light Mode toggle was overlapping on Sign-In Button, so commented it out, for future un-commenting and later work. Also, added 30px of margin-top and margin-bottom to the Sign In div.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

BEFORE:
image

AFTER:
image
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please let me know if everything is alright. Also, please add the GSSoC - Extd and Hacktoberfest labels. Thank You!!

yashksaini-coder and others added 3 commits October 8, 2024 14:43
…. The Light Mode toggle was overlapping on Sign-In Button, so commented it out, for future un-commenting. Also, added 30px of margin-top and margin-bottom to the Sign In div
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 4:18pm

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 799cfb4
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/67055b5570f39300083844c4
😎 Deploy Preview https://deploy-preview-310--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarinsanyal sarinsanyal mentioned this pull request Oct 8, 2024
4 tasks
@PriyaGhosal
Copy link
Owner

image
@sarinsanyal
Due to a conflicting issue, some code was removed from the repository. We are investigating the matter. Meanwhile, please check on your end, and if your PR code no longer exists, kindly create the PR again for merging. Thank you for your understanding!

@PriyaGhosal PriyaGhosal closed this Oct 9, 2024
@sarinsanyal sarinsanyal deleted the Work-on-Issue-#309 branch October 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Improving Sign - In Page.
3 participants