Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the header issues from issue#350 #355

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

Nimit1775
Copy link
Contributor

@Nimit1775 Nimit1775 commented Oct 9, 2024

Related Issue

#350

Fixes: #(issue no.)

#350

[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

in this PR i have fixed the overlapping header issue , made a dropdown for the header in smaller screens , made the header responsive , made the exclusive deals section responsive too
fixes issue :- #350

Type of PR

  • Bug fix
  • Feature enhancement

Screenshots / videos (if applicable)

https://drive.google.com/drive/folders/1oNAG6xFbXo2lVd_tymhkTYPzkI0jaiVK?usp=drive_link
( attached google drive link for screen shots )

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 7:22am

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 359a517
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/67062f42a74a5000087309c5
😎 Deploy Preview https://deploy-preview-355--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nimit1775
Copy link
Contributor Author

@PriyaGhosal for the images kindly check the google drive link provided
i have fixed the issue #350

@anuragverma108 anuragverma108 merged commit 2813a2d into PriyaGhosal:main Oct 9, 2024
1 of 2 checks passed
@Nimit1775
Copy link
Contributor Author

@anuragverma108 @PriyaGhosal can you please add the correct labels in this PR for gssoc and hacktoberfest so that it shows in the leaderboard
thanks

@Nimit1775
Copy link
Contributor Author

and also the gssoc-ext label @anuragverma108 @PriyaGhosal

@Nimit1775
Copy link
Contributor Author

please add the labels for gssoc @PriyaGhosal

@Nimit1775
Copy link
Contributor Author

Nimit1775 commented Oct 9, 2024 via email

@MastanSayyad
Copy link
Collaborator

@anuragverma108 @PriyaGhosal Program Manager this side
Could you make sure to add the required labels whenever you merge the PR? Also you didn't add me as a collaborator to your project, please do so that I can monitor your project

@MastanSayyad
Copy link
Collaborator

@yashksaini-coder Why are your commits here in his PR?

image

@Nimit1775
Copy link
Contributor Author

@MastanSayyad his commits are also getting shown in PR #378 which is my PR

@yashksaini-coder
Copy link
Contributor

@yashksaini-coder Why are your commits here in his PR?

image

Let me check this real quick @MastanSayyad

@yashksaini-coder
Copy link
Contributor

@Nimit1775 I apologize I am fixing this bug right now.

@PriyaGhosal
Copy link
Owner

@MastanSayyad I was merging the PR and adding labels, but I might have missed something by mistake. Additionally, I was unable to add you as a collaborator because the GitHub ID given in email address was not accessible. I will add you shortly.

@PriyaGhosal
Copy link
Owner

PriyaGhosal commented Oct 9, 2024

@Nimit1775 Great Contribution in GSSOC-EXT 2024 🎉🎉🎉🎉

@yashksaini-coder
Copy link
Contributor

can you check this ASAP #406 its a bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants