Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #715 Dark mode / light mode fixed #727

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

MOHIT-IITP
Copy link
Contributor

@MOHIT-IITP MOHIT-IITP commented Oct 15, 2024

Related Issue

Fixed the dark and light mode , not working properly , some element were not visible .

Fixes: #715

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Before :
Here button was not visible
Screenshot 2024-10-15 at 1 25 51 PM
After : And also visible in dark and light mode
Screenshot 2024-10-15 at 1 50 02 PM

Here Text was not visible
Screenshot 2024-10-15 at 12 00 32 PM
Screenshot 2024-10-15 at 12 00 26 PM
Screenshot 2024-10-15 at 11 54 51 AM
After:
Screenshot 2024-10-15 at 1 42 39 PM

Screenshot 2024-10-15 at 1 42 52 PM Screenshot 2024-10-15 at 1 42 59 PM

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 7840991
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/670e296be3127800080dd6f9
😎 Deploy Preview https://deploy-preview-727--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 8:36am

@PriyaGhosal PriyaGhosal merged commit 170d319 into PriyaGhosal:main Oct 15, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

PriyaGhosal commented Oct 15, 2024

@MOHIT-IITP
Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODE CHANGE: Making site responsive with dark and light mode & making the footer
2 participants