Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #827 Solved :- Added Registration Pop up #832

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

PrAyAg9
Copy link
Contributor

@PrAyAg9 PrAyAg9 commented Oct 16, 2024

Related Issue

None

Fixes: #827

Description

  • A pop up is added on the landing page which will provoke users to register via exciting offer
  • Clicking on no thanks or anywhere outside body will close the pop up

Type of PR

  • Bug fix
  • [yes ] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

  1. This is how it will look like:-
    image

I did have more design, i shared it on issue description #827

Checklist:

  • [yes ] I have made this change from my own.
  • [ yes] My code follows the style guidelines of this project.
  • [ yes] I have performed a self-review of my own code.
  • [ yes] I have commented my code, particularly in hard-to-understand areas.
  • [yes ] I have made corresponding changes to the documentation.
  • [yes ] My changes generate no new warnings.
  • [ yes] I have tested the changes thoroughly before submitting this pull request.
  • [ yes] I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 11:38am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit b3bc195
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6710f72c40695400080325f9
😎 Deploy Preview https://deploy-preview-832--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PrAyAg9
Copy link
Contributor Author

PrAyAg9 commented Oct 16, 2024

@PriyaGhosal I've attached the current look of pop up here as you can see up in description.

Other design is attached on the issue page you can also see that
Could you raise this issue from level 1 category as this requires a lot of time
- I hope you like it, Thank you.

@PrAyAg9
Copy link
Contributor Author

PrAyAg9 commented Oct 17, 2024

@samarth-6 Please review and approve it?

@PriyaGhosal
Copy link
Owner

@PrAyAg9 You have done great contribution but "No thanks" button is not working when I am checking it in preview. Please look into it . If it doesn't work you can put right corner cross symbol.

@PrAyAg9
Copy link
Contributor Author

PrAyAg9 commented Oct 17, 2024

@PriyaGhosal Could you please check if it is working now?

@PriyaGhosal PriyaGhosal merged commit d480392 into PriyaGhosal:main Oct 17, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

@PrAyAg9
Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Adding a Registration Pop up on Landing Page
2 participants