Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied glass effect on navbar #894

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Kiran-F
Copy link
Contributor

@Kiran-F Kiran-F commented Oct 17, 2024

Related Issue

none
Fixes: #(844)

Description

I've applied glass effect on the navbar as it was creating visibility issue of the names of the tabs written on navbar.
issue# 838 is fixed in this PR.

Type of PR

UI is enhanced.

  • Bug fix
  • Feature enhancement

Screenshots / videos (if applicable)

Before:
Screenshot (694)

After:
Screenshot (695)

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Kindly add gssoc-ext, hacktoberfest, hacktoberfest-accepted labels in this PR and it's ready to merge now.
Kindly review it and let me know if there are any changes to be made.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 1:29pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 851c5d4
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/67111114af057d00081a57ea
😎 Deploy Preview https://deploy-preview-894--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kiran-F
Copy link
Contributor Author

Kiran-F commented Oct 17, 2024

@PriyaGhosal review it and let me know if there are some changes to be made.
add the labels too.

@PriyaGhosal PriyaGhosal merged commit 0806e34 into PriyaGhosal:main Oct 17, 2024
7 checks passed
@PriyaGhosal
Copy link
Owner

@Kiran-F Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants