Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #870 At carrier page - Date Input Field Allows Invalid Six-… #875

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

byteom
Copy link
Contributor

@byteom byteom commented Oct 27, 2024

Fix issue #870 At carrier page - Date Input Field Allows Invalid Six
fix: Restrict Date Input to 4-Digit Year in Job Application Form

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #870

Description

Updated the date input field in the job application form to restrict the year input to only 4 digits. Changes include:

  • Added min and max attributes to restrict year range.
  • Added JavaScript validation to automatically limit input to a 4-digit year.
  • Applied pattern attribute for additional input guidance.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

…nvalid Six-Digit Year in Job Application Form
Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 2:45pm

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit c458259
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/671e52207f31b400096afebc
😎 Deploy Preview https://deploy-preview-875--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@byteom
Copy link
Contributor Author

byteom commented Oct 27, 2024

/accept it please

@byteom
Copy link
Contributor Author

byteom commented Oct 28, 2024

/hey accept it

@PriyaGhosal PriyaGhosal merged commit 0f76d06 into PriyaGhosal:main Oct 30, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

@byteom
Great contribution ! 🎉
Your pull request has been successfully merged! Also Take a moment to ⭐ Star the repository if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] At carrier page - Date Input Field Allows Invalid Six-Digit Year in Job Application Form
2 participants