Fix: Corrupted JPEG #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| if image is None: | ||
| try: | ||
| image = np.array(Image.open(BytesIO(jpeg))) |
There was a problem hiding this comment.
Seems to work as expected although is there a reason why imdecode was replaced with a method from pillow? Replacing that line with the old imdecode method seems to still work fine and avoids another dependency.
There was a problem hiding this comment.
imdecode can sometimes return corrupted data, but it rarely happens, so prioritizing dependencies should be fine.
There was a problem hiding this comment.
I suppose, seems like we're already importing pillow in other files anyways.
|
|
RamesTheGeneric
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the data length from the SOI (Start of Image) and EOI (End of Image) markers in the JPEG data sent by the ESP32.
Add error detection for JPEG data.