-
Notifications
You must be signed in to change notification settings - Fork 61
Add series #6
Comments
Hi @knjk04 . Is it still open? I wanna work on this issue... |
Hi, @Sajal193 . Yes, it is. Before I assign you to the issue, what's your implementation approach? |
Hello, I would like to take a shot at this. My proposal:
Does that make sense ? |
Hello, thanks for your interest in this!
The Id ad name of the series sounds good. Perhaps we don't need a series order number if a |
I see an issue with my proposed approach where a Unique Series Id will relate to a single Book Id (When we need it to relate with multiple book id's). Maybe we can:
As to have a unique |
I confirmed that A |
Does the serial number represent the order a book is in a series?
So there would be a many-to-many relationship between
Sorry, what do you mean by 'skip' here? |
|
@kev711 Thanks! Feel free to reach out by creating a GitHub discussion or by asking on our #help channel on Slack if you need anything! |
@kev711 I think a book should be in at most one series and a series can contain many books. Should the relationship between series and book be many-to-one? Also, we're now using Gradle & DGS, so I'd recommend rebasing your branch with |
I think in future, if the need arises to have a book in multiple series (e.g. Author specials, author etc.) then that would be needed. |
@kev711 How are you getting on with this? |
Still working on this. Not stuck as such, will create a PR on this in a few days. |
That's fine, thanks for the update! |
About this requirement, should these repository functions be a part of Entity
|
Good question! I think it should be a part of the |
@knjk04 |
If a book is in a series, it should be possible to see:
The text was updated successfully, but these errors were encountered: