Add series issue 6 #81
Conversation
…lds are Not Null, minor corrections
|
Thanks for working on this! I'll review this shortly! |
src/main/java/com/karankumar/booksapi/model/BookSeriesMapping.java
Outdated
Show resolved
Hide resolved
src/main/java/com/karankumar/booksapi/model/BookSeriesMapping.java
Outdated
Show resolved
Hide resolved
src/test/java/com/karankumar/booksapi/repository/BookSeriesRepositoryTest.java
Outdated
Show resolved
Hide resolved
…tation-82 Add delete book mutation
|
I am working on resolving the other comments... |
Hi @knjk04, Also, made changes for other comments. |
|
Hi @kev711, We're using integration tests for that. I noticed you have some DataJpaIntegration tests. I'll need to review this closer, but that should be fine |
…lds are Not Null, minor corrections
|
Working on it... |
…ies-issue-6 # Conflicts: # src/main/java/com/karankumar/booksapi/model/Book.java # src/test/java/com/karankumar/booksapi/model/BookSeriesMappingTest.java # src/test/java/com/karankumar/booksapi/repository/BookRepositoryTest.java # src/test/java/com/karankumar/booksapi/repository/BookSeriesMappingRepositoryTest.java
|
Merge conflicts resolved. |
|
There are quite a few unrelated changes to the issue you worked on in this PR diff. Would it be possible to create a new PR to make it easier to review? |
|
Sure. |
|
Closing this one, since its not allowing me to open a new one. |
Summary of change
If a book is in a series, it should be possible to see:
Its position in the series
com.karankumar.booksapi.repository.BookRepository.getBookPositionInBookSeries()The name of the series (e.g. 'Harry Potter' for the Harry Potter books)
com.karankumar.booksapi.repository.BookRepository.getAllBookSeriesForBook()Other books in the same series
com.karankumar.booksapi.repository.BookSeriesMappingRepository.getAllBooksByBookSeries()Related issue
Closes #6
Pull request checklist
Please keep this checklist in & ensure you have done the following:
Read, understood and adhered to our contributing document.
Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123Set this pull request to 'draft' if you are still working on it
Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub