feat: Add caching mechanism to Unit Fields #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eraging cache cherry-pick "feat(Core/Optimization): Optimize build of units update object by leveraging cache." azerothcore/azerothcore-wotlk@1f640c9 Co-authored-by: Anton Popovichenko <[email protected]>
reverts 2f04c48 "Core/PacketIO: Reduce size of SMSG_UPDATE_OBJECT by trimming trailing zeros in values updatemask" Pointers to positions in Bytebuffer are no longer valid if trailing zeros are removed
…n the same world update tick. "fix an issue when the client sees dead NPCs when they are not" cherry-pick "fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick." azerothcore/azerothcore-wotlk@04acfd9 Co-authored-by: Anton Popovichenko <[email protected]>
|
Prioing review and my initial testing asap due to the high bounty. Thank you @sogladev This one might require me to actually ship a build to our internal realm for QA team to try and break not just me so give me some time and I'll get back to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Cherry-pick the Unit Field cache system from AzerothCore
Some unit fields are set differently in AzerothCore. I left how TC handles the setting of those fields.
Target branch(es): 335
Issues addressed:
Tests performed: (Does it build, tested in-game, etc)
Built with TC 382bf77
Epoch 08574fef9c7c
Known issues and TODO list: