Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong describe of device registry in protocol.md #910

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hurricane1988
Copy link

What type of PR is this?

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

Fix the wrong describe of device registry in protocol.md

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Fix the wrong describe of device registry docs/develop/protocol.md

Does this PR introduce a user-facing change?:
YES

@hami-robott hami-robott bot added kind/bug Something isn't working dco-signoff: no labels Mar 3, 2025
Copy link
Contributor

hami-robott bot commented Mar 3, 2025

Welcome @hurricane1988! It looks like this is your first PR to Project-HAMi/HAMi 🎉

@hami-robott hami-robott bot added the size/XS label Mar 3, 2025
@hami-robott hami-robott bot requested review from archlitchi and wawa0210 March 3, 2025 14:28
Copy link
Contributor

hami-robott bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hurricane1988
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lengrongfu
Copy link
Member

lengrongfu commented Mar 5, 2025

thanks you fix, look good to me. but you need solve dco.

/LGTM

@lengrongfu
Copy link
Member

@hurricane1988 Please sign dco.

Copy link
Contributor

hami-robott bot commented Mar 7, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 8cc02e8 Add the link to other markdown document of design.md, that much more easy to redirect

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants