-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wrong describe of device registry in protocol.md #910
base: master
Are you sure you want to change the base?
Conversation
Welcome @hurricane1988! It looks like this is your first PR to Project-HAMi/HAMi 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hurricane1988 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks you fix, look good to me. but you need solve dco. /LGTM |
@hurricane1988 Please sign dco. |
Signed-off-by: hurricane1988 <[email protected]>
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
Fix the wrong describe of device registry in protocol.md
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
YES