Fix UT not be properly executed during CI phase #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Signed-off-by: limengxuan <[email protected]>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/lgtm |
yangshiqi
pushed a commit
to yangshiqi/HAMi
that referenced
this pull request
Mar 5, 2025
* fix make test not working properly Signed-off-by: limengxuan <[email protected]>
yangshiqi
added a commit
to yangshiqi/HAMi
that referenced
this pull request
Mar 6, 2025
factory.go: 将client的实例管理逻辑统一，方便调用和切换fake。兼容当前 KubeClient 全局变量的使用。 k8s_client.go: 统一实现 k8s 真实调用行为, 记录调用日志，去掉全局变量。 2.修改 util 和 util_test 中的相关调用, 统一 util_test 中测试用例的命名风格。 本次修改仅关注于 real 和 mock 分离，后续将完善更多 ut 测试，逐步替换当前 client 中的直接调用方式。 3.Fix UT not be properly executed during CI phase (Project-HAMi#911) 4.兼容当前新老调用 KubeClient 的用法，特别是 fake 替换时 Signed-off-by: yangshiqi <[email protected]>
yangshiqi
added a commit
to yangshiqi/HAMi
that referenced
this pull request
Mar 6, 2025
factory.go: 将client的实例管理逻辑统一，方便调用和切换fake。兼容当前 KubeClient 全局变量的使用。 k8s_client.go: 统一实现 k8s 真实调用行为, 记录调用日志，去掉全局变量。 2.修改 util 和 util_test 中的相关调用, 统一 util_test 中测试用例的命名风格。 本次修改仅关注于 real 和 mock 分离，后续将完善更多 ut 测试，逐步替换当前 client 中的直接调用方式。 3.Fix UT not be properly executed during CI phase (Project-HAMi#911) 4.兼容当前新老调用 KubeClient 的用法，特别是 fake 替换时 Signed-off-by: yangshiqi <[email protected]>
yangshiqi
pushed a commit
to yangshiqi/HAMi
that referenced
this pull request
Mar 6, 2025
* fix make test not working properly Signed-off-by: limengxuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug