Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add namespace override for multi-namespace deployments #924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chinaran
Copy link
Contributor

@chinaran chinaran commented Mar 9, 2025

What type of PR is this?

/kind deployment

What this PR does / why we need it:

Add namespace override for multi-namespace deployments in combined charts.

Copy link
Contributor

hami-robott bot commented Mar 9, 2025

@chinaran: The label(s) kind/deployment cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind deployment

What this PR does / why we need it:

Add namespace override for multi-namespace deployments in combined charts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

hami-robott bot commented Mar 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chinaran
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 64.41% <ø> (+17.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chinaran
Copy link
Contributor Author

@archlitchi @wawa0210 Please check out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant