Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transform to Subtract Images #8301

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Conversation

anamatoso
Copy link

Hello all,

I've created a transform to subtract two images.
I've created the tests and passed all integration tests.
Hope you find it useful.

Let me know if there is anything else still to do.

Description

Adds a transform for subtracting images.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Ana Matoso and others added 17 commits March 22, 2024 16:25
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 0ff2d45, 6d47218, 670e39d, e7d307b, 7c41ce5, d1f0257, 259ed0f, 6b50562

Signed-off-by: Ana Matoso <[email protected]>
Signed-off-by: Ana Matoso <[email protected]>
Signed-off-by: Author Name <[email protected]>
…ly.github.com>

I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: e7d307b
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 7c41ce5
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: d1f0257
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 259ed0f
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 6b50562
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: b837235
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 75d4d15
I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 8695428

Signed-off-by: Ana Matoso <[email protected]>
…ly.github.com>

I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 6a6243c

Signed-off-by: Ana Matoso <[email protected]>
Signed-off-by: Ana Matoso <[email protected]>
…ly.github.com>

I, Ana Matoso <[email protected]>, hereby add my Signed-off-by to this commit: 261c81d

Signed-off-by: Ana Matoso <[email protected]>
@ericspod
Copy link
Member

Hi @anamatoso thanks for the contribution. This class is probably something very specific to your use case so I'm not sure about how general purpose it is. We don't have transforms for doing other arithmetic operations, so I wonder if it would be better defining a generic transform which collects selected keys together and applies some callable to those items. This could be used as a new base for ConcatItemsd as well. What do you think? The class as-is seems fine to me if you'd rather just stick to committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants