Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42 refactor computation engine to be submodule for orchestrator for pipeline tests #43

Conversation

lfse-slafleur
Copy link
Member

@lfse-slafleur lfse-slafleur commented Apr 30, 2024

Needs to be coordinated with Project-OMOTES/orchestrator#36

… docker compose file path as arguments. Also cleanup the scripts.
@lfse-slafleur lfse-slafleur self-assigned this Apr 30, 2024
…-engine-to-be-submodule-for-orchestrator-for-pipeline-tests
…-engine-to-be-submodule-for-orchestrator-for-pipeline-tests
@lfse-slafleur lfse-slafleur marked this pull request as ready for review May 6, 2024 14:31
@lfse-slafleur
Copy link
Member Author

Tests will not succeed until we release and merge Project-OMOTES/orchestrator#36 into here as the database setup was moved. Right now, neither computation-engine setup nor the orchestrator (old version) is performing the db setup which causes the system to throw an error the first time a query to postgresql is performed.

Copy link
Contributor

@MarkTNO MarkTNO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer with the database migration stuff moved and using as submodule instead of double setup components scripts in the orchestrator!

Just some minor comments.

scripts/setup_influxdb.sh Outdated Show resolved Hide resolved
scripts/setup_orchestrator_postgres_db.sh Outdated Show resolved Hide resolved
scripts/setup_orchestrator_postgres_db.sh Show resolved Hide resolved
scripts/setup_rabbitmq.sh Outdated Show resolved Hide resolved
Base automatically changed from 40-add-basic-system-tests to main May 14, 2024 14:36
@lfse-slafleur lfse-slafleur merged commit b4a8d52 into main Jun 3, 2024
1 check passed
@lfse-slafleur lfse-slafleur deleted the 42-refactor-computation-engine-to-be-submodule-for-orchestrator-for-pipeline-tests branch June 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor computation engine to be submodule for orchestrator for pipeline tests
2 participants