Fix json rendering of large osm ids #7096
Conversation
imannamdari
force-pushed
the
fix-large-osmids-json-rendering
branch
from
e5df0c4 to
ef96e49
Compare
| @@ -54,7 +54,10 @@ template <typename Out> struct Renderer | |||
| // `fmt::memory_buffer` stores first 500 bytes in the object itself(i.e. on stack in this | |||
| // case) and then grows using heap if needed | |||
| fmt::memory_buffer buffer; | |||
| fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{:.10g}"), number.value); | |||
| if (static_cast<std::uint64_t>(number.value) == number.value) | |||
| fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{}"), static_cast<std::uint64_t>(number.value)); | |||
There was a problem hiding this comment.
Is the if/else block really needed? Can't a single line below handle the big integer number up to 18446744073709551615 (which is 2^64-1)?
fmt::format_to(std::back_inserter(buffer), FMT_COMPILE("{}"), static_cast<std::uint64_t>(number.value));
There was a problem hiding this comment.
Ah, nevermind, I see that it would break the fractional numbers
There was a problem hiding this comment.
Exactly. For floating-points there gonna be problems.
The previous approach implemented before this commit can be found here (and it works fine):
A more robust solution could be separating floats from integers. Instead of Number struct, we can have Float and Integer structs for example. Each with their own json rendering.
However, that's a significant change! :D
If you agree with this approach (separating floats from integers), I can work on it in another pull request.
There was a problem hiding this comment.
Dear @DennisOSRM and @SiarheiFedartsou now that CI build is working again, could you please consider merging this fix by @imannamdari ?
In the past week I have tested his fix with map matching and it really seems to fix the problem with large OSM node/way ids.
And please consider adding a new git tag v5.28.1 after the merge?
Because the current tag v5.27.1 is already three years old and it would be nice to set a newer stable source code "checkpoint" for all users.
Issue
Fix #7016
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?